Repository navigation
gh-132113: Make EnvironmentVarGuard thread safe - #132128
srinivasreddy wants to merge 6 commits into
Conversation
|
Looks related to #132113 - can you add the issue number to the title? edit: re "Please do not review yet", you can mark this PR as a draft by clicking the "Convert to draft" button under "Reviewers" in the right-hand column |
srinivasreddy
changed the title
EnvironmentVarGuard thread safeEnvironmentVarGuard thread safe
fbe6202 to
a8a295f
Compare
|
Could you add a news entry? thanks! |
|
All commit authors signed the Contributor License Agreement. |
|
Can you add a test please? and/or confirm that the reproducer given on the issue is fixed? |
| for v in linked: | ||
| self.assertIsInstance(v, int) | ||
|
|
||
| def test_threadsafe_environmentvarguard(self): |
There was a problem hiding this comment.
This test should be executed more than once. I think, so I would suggest doing something like that (when I executed the script in my terminal, I needed more than one script execution to see the issue)
def test_threadsafe_environmentvarguard(self):
for _ in range(100):
self._test_threadsafe_environmentvarguard()
def _test_threadsafe_environmentvarguard(self):
...
|
Following Serhiy's explanation and considering I actually didn't think enough about this, I closed the issue. |
test.support.os_helper.EnvironmentVarGuardis not thread safe #132113